|
Some suggestions / bugs from Rickx from the XBMC forum. Repasting here to track them. Not sure I like the tone of voice but the ideas are good. I have responded to some of them and some will get done and others not. To all testers: Be patient. The code already does more than a number of scrapers but it is far from where I would like to take it. There is only so much time I have (and that is pretty much every evening). The one thing I have to emphasize is that Media Reader does not have multi-language support and is not likely to have it anytime soon. The way I see it there is really only major demand for German and English. If you really, really want to work on this, I'll put it on svn (actually, it already is) and have at it. But the code is going through such rapid and profound changes at this point in time that it would not be very sensible to keep merging changes.
- first of all, this app is still in a very immature phase, I would say alpha more than beta...but the point is: it changes an existing collection without any warning. In my case that meant messing things up more than adding missing informations. But I'll come to that later. - regarding movies, it changes the file name, then adds other files (nfo, tbn, fanart) using that new name. That's what I think is not ok: - the matching of the imdb is not well done (I have worse results than using xbmc). - the choice of renaming the file is not good either: having movies in different languages, I prefer to keep the translated movie names: why make everything english? When you add wrong matches to translations, you may guess the mess... - the choice of adding fanart and picture should probably be a choice as well. default should add the nfo only. or make that a choice... - the existing subtitle files are "orphaned". they're not renamed and so will be lost most of the times. - all the movies consisting of 2 parts (2 cds) are not recognized as such and instead treated as the same film twice. For "Clerks" and "Clerks 2" both in two parts I now have 4 times the same "Clerks" movie...as example. - the browser in os x is buggy, so I can not correct the wrong matches - the error was already posted here. So now what I would change:
- Add multipart movie regexp - should be default to avoid the mentioned error. - do definitely a better imdb match handling: it might be imdb's fault, but the first match is the correct one on a rather low rate. One option could be that of sorting the search results, another to look for exact matches only. Yet another that of using scraperxml (--> search). - consequently do all the automated steps only on the exact matches. or make this a choice. - all the renaming and adding: I'd suggest to store all those infos in a tmp folder in the "batch-phase". Then show the results to the user and apply them only if approved (possibly giving choice to check what to apply/not apply...but that could become complicated) - pre-existing files must be respected: exisiting srt/sub etc. must be taken into account - an advanced option could be that of moving a all-files-in-one-folder structure to a each-movie-in-its-subfolder and/or back. - a new feature which is missing is the already mentioned studio tag, probably the one tag making nfo files most useful as of now. the nicest feature of such an implementation would be that of opening the movies to get infos from the movie itself like resolution (--> sd, 720, 1080 etc.), audio + subs etc. Only the studio name itself must be grabbed from the filename (unless that can be fetched from imdb as well...). There are lots of threads about this.
I made screenshots of the batch results. That's because they're inserted line by line in a list control instead of concatenated in a big text field (so I could have copied/pasted the whole thing out). I will not post them here (20 files), but if you're interested, I may email them.
some examples of my matches: leg dich nicht mit zohan an.mpg (german title) --> matched as "vento di primavera (1958)" (italian...) :shocked: renaissance.mpg --> star trek - first contact (1996) [wtf*k%&£$!!]:stare: the nines (2008) --> dogville (2003) :oo: and what about the rocker matched as The Hurt Locker (2008) ??!!!:sad:
p.s. the vlc player chosen as movie player does not work (or the play function anyway...). And I'm using 0.44.[/QUOTE] |